Skip to content

Properly detect and print DB version according to it's type #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 23, 2025
Merged

Properly detect and print DB version according to it's type #62

merged 1 commit into from
Apr 23, 2025

Conversation

vponomaryov
Copy link
Collaborator

No description provided.

@vponomaryov
Copy link
Collaborator Author

vponomaryov commented Apr 11, 2025 •
edited
Loading

Comparison:

info: Connecting to ["172.17.0.2"]...
info: Connected to '' cluster running ScyllaDB 2025.1.0-0.20250325.9dca28d2b818 with build-id 3a706305ef8ac6f14575e4f3441968f67d29d38c
info: Preparing...
info: Warming up...
info: Running benchmark...
CONFIG ═════════════════════════════════════════════════════════════════════════════════════════════════════════════════════
            Date            Fri, 11 Apr 2025                                                        
            Time            14:08:39 +0300                                                            
         Cluster                                                                                      
      Datacenter                                                                                      
      DB version            ScyllaDB 2025.1.0-0.20250325.9dca28d2b818 with build-id 3a706305ef8ac6f14575e4f3441968f67d29d38c
...                                                            

info: Connecting to ["172.17.0.5"]... 
info: Connected to 'Test Cluster' cluster running Cassandra 5.0.4
info: Preparing...
info: Warming up...
info: Running benchmark...
CONFIG ═════════════════════════════════════════════════════════════════════════════════════════════════════════════════════
            Date            Fri, 11 Apr 2025                                                          
            Time            14:09:02 +0300                                                            
         Cluster            Test Cluster                                                              
      Datacenter                                                                                      
      DB version            Cassandra 5.0.4                                                           
...

@vponomaryov vponomaryov force-pushed the read-scylla-version branch from 3fc7145 to 5007e9c Compare April 11, 2025 11:29
@vponomaryov vponomaryov requested a review from Copilot April 11, 2025 11:33
Copilot
Copilot AI reviewed Apr 11, 2025
View reviewed changes
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

@vponomaryov vponomaryov requested a review from fruch April 23, 2025 12:00
fruch
fruch approved these changes Apr 23, 2025
View reviewed changes
Copy link
Collaborator

@fruch fruch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vponomaryov vponomaryov merged commit 96342f7 into main Apr 23, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@fruch fruch fruch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vponomaryov @fruch