ansible-scylla-node: run nodetool upgradesstables after upgrade#532
Open
ManjotS wants to merge 4 commits into
Open
ansible-scylla-node: run nodetool upgradesstables after upgrade#532ManjotS wants to merge 4 commits into
ManjotS wants to merge 4 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the ansible-scylla-node upgrade flow to optionally run nodetool upgradesstables after a node upgrade, aiming to ensure SSTables (including system keyspaces) are rewritten to the current format during rolling upgrades.
Changes:
- Added a new role default
upgrade_sstables(defaulttrue) to control whether SSTables are upgraded post-upgrade. - Added a post-upgrade task that runs
nodetool upgradesstablesafter Scylla starts and the CQL port is reachable.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| ansible-scylla-node/tasks/upgrade/post_upgrade.yml | Runs nodetool upgradesstables after starting Scylla and waiting for CQL. |
| ansible-scylla-node/defaults/main.yml | Introduces upgrade_sstables default and documents its behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
1 task
vreniers
requested changes
Jul 20, 2026
vreniers
left a comment
vreniers
left a comment
Collaborator
There was a problem hiding this comment.
Please make the PR against the dev branch.
Add upgrade_sstables (default true) and invoke nodetool upgradesstables in post_upgrade once CQL is up, so rolling upgrades rewrite SSTables to the current format (including system keyspace drifts). Co-authored-by: Cursor <cursoragent@cursor.com>
Wait for nodetool readiness before upgradesstables, and bound runtime via upgrade_sstables_timeout_seconds (async/poll) like cleanup/repair. Co-authored-by: Cursor <cursoragent@cursor.com>
Native nodetool since 2025; task name no longer mentions JMX. Co-authored-by: Cursor <cursoragent@cursor.com>
ManjotS
force-pushed
the
cursor/upgrade-sstables-post-upgrade
branch
from
July 21, 2026 01:12
157b77b to
046daf5
Compare
Collaborator
Author
|
Addressed @vreniers review:
|
1 task
vreniers
requested changes
Jul 24, 2026
vreniers
left a comment
vreniers
left a comment
Collaborator
There was a problem hiding this comment.
Upon closer look, I have 1 more comment.
Set upgrade_sstables default to {{ upgrade_major }} so SSTables are
rewritten only on major upgrades by default and skipped on minor
upgrades, per review. Still overridable.
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
upgrade_sstablesrole var (defaulttrue) toansible-scylla-nodenodetool upgradesstablesinpost_upgrade.ymlafter CQL is up, so rolling upgrades rewrite SSTables to the current format (including system keyspace drifts)Context
PR discussion: upgradesstables should live in the ansible upgrade procedure rather than a one-off playbook. Rolling upgrade playbooks already use
serial: 1, so this runs one node at a time.Test plan
upgrade_sstables=true(default) — confirmnodetool upgradesstablesruns after CQL wait-e upgrade_sstables=false— confirm task skippedMade with Cursor