Conversation
|
Initially was preparing this change with go1.18 on my setup, and for local source/repo it was able to get version details from build info as is, i.e. the VCS info was automatically included in the binary by default so debug.ReadBuildInfo() was providing everything needed. |
|
The step of setting the version information during the build of the tool is due to be added after the PR that updates the makefile and Dockerfile is merged (#158) |
438fcfe to
b48a6f9
Compare
This change introduces a pair of CLI options - `-version` and `-version-json` - to print the verions of scylla-bench and gocql driver, in human-readable or JSON formats respectively. Closes: scylladb#156
b48a6f9 to
2085a06
Compare
|
The linting step check is failing due to check is missed in makefile (as mentioned here - #158 (comment)) |
|
Some tests of getting version info when building scylla-bench differently: make build make build with custom driver version local go build from scylla-bench released/tagged version: |
|
@soyacz @vponomaryov |
|
the pipeline here is broken, can you look into it ? |
|
Fixed on master |
This change introduces 2 new CLI options to report the versions of scylla-bench and scylla-gocql-driver:
-versionfor printing the versions info in human readable format-version-jsonfor printing the versions info in JSOn formatFor both scylla-bench and driver version the layered approach of extracting informaion is used
Example of the new CLI options results: