feature(tests): add tests for main.go function and improve modes.go tests #194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tests Signed-off-by: Dusan Malusev <[email protected]>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
main.goandmodes.gowere not covers by unit tests at all, and many bugs were surfaced at these locations. This covers most of the functionality in these files to avoid previous hiccups from the past in the futureNote
tparallellinter had to be removed, at it causesgolangci-lintto fail. Ins-bmost tests frommain.gothat need to test different outputs based on the input flags, modify global variables, thust.Parallel()call is not feasible at this moment (large refactor of the code base must be done to allow parallel testing).gotestwill outputdata raceswhen global variables are changed and this makes tests flaky