docs(copilot-instructions): clean up merge markers and stale facts#288
docs(copilot-instructions): clean up merge markers and stale facts#288CodeLieutenant wants to merge 3 commits into
Conversation
…h stale facts The file accumulated three sets of unbookended merge markers (`||||||| <ref>` and `=======` without their `<<<<<<<` / `>>>>>>>` counterparts) plus 3-4× duplicated sections from botched merges/cherry-picks. Rewrote to a single consolidated version, corrected the Go version (1.24 -> 1.25) and the gocql replace target (v1.15.0 -> v1.18.0) against current go.mod, refreshed the package layout to match pkg/, and dropped the obsolete "make check is broken" warning now that .golangci.yml and the Makefile target are healthy. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Signed-off-by: Dusan Malusev <dusan@dusanmalusev.dev>
|
I would recommend splinting this to two PRs |
Splitting it into two PRs does not much sense, since these skills are from skills.sh and they are installed and managed with a package manager, It would be even safe to gitignore them and then everybody who wants to work on s-b should install it as a part of some kind of setup phase, but everybody will forget that, so it's much easier just to vendor it and leave it in the source, since it will be updated with skills.sh cli, and everybody will benefit |
| @@ -0,0 +1,142 @@ | |||
| --- | |||
| name: find-skills | |||
There was a problem hiding this comment.
this has nothing to do with scyla-bench
We could think of separate scylla repo for these or posting it to proper slack channel for others to use
soyacz
left a comment
There was a problem hiding this comment.
I see many skills installed, did you have a chance to implement something with their use? won't they clash or make agent to load too many of them?
I did not test it with scylla bench, but I did in gemini. For quite some time gemini has exact skills, and they work great. LLMs are smart enough to load only whats needed (at least with opencode and Claude, haven't tested others). They do not interfere with each other and no overlap from what I've seen and based on whats in there. |
Summary
.github/copilot-instructions.mdhad accumulated three sets of unbookendedgit merge markers (
||||||| <ref>and=======without their<<<<<<</>>>>>>>counterparts) plus the same sections duplicated 3-4× from botchedmerges or cherry-picks. Codex/Copilot couldn't usefully consume it.
This PR rewrites the file to a single consolidated version and corrects a
few facts that had drifted from current state:
Project Structure / Benchmarking Modes / Building and Running /
Development Workflow / Troubleshooting sections.
go.mod.go.mod(PR chore(deps): update module github.com/scylladb/gocql to v1.18.0 #287bumped this and the doc was never updated).
pkg/tree to list the packages that actually existtoday (
config,ratelimiter,results,stack,testrun,testutil,tools,worker,workloads) plusinternal/clockwitha note that
time.Now/Sleepshould not be called directly.make checkis broken — don't run it" warning..golangci.ymland the Makefile target both look healthy now; theguidance was steering contributors away from a working local lint
check. Reinstated
make checkin the pre-commit checklist.make build-sct-docker-image,make fieldalign,and the integration test entrypoints (
TestIntegration*,TestMemoryLeak*) with their env-var gates.