fix(scylla_cluster): improve version str extraction for Manager #677
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stdout returned by sctool version contains two versions and looks like 'Client version: 3.6.0\nServer version: 3.6.0\n'. In Manager, server and client version are always the same, thus, stdout can be splitlined and the first part taken and passed to ComparableScyllaVersion(). In current implemented the input like `3.6.0\nServer version: 3.6.0\n` is set which ComparableScyllaVersion() somehow manages to handle but which is not technically correct
fruch
force-pushed
the
manager-fix-version-parsing
branch
from
52bebde to
be8f530
Compare
Contributor
|
@mikliapko this is still needed ? |
Contributor
Author
Yes, in general, it doesn't make any tests to fail (it was discovered during debugging) but can be improved to avoid potential issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stdout returned by
sctool versioncontains two versions and looks likeClient version: 3.6.0\nServer version: 3.6.0\n.In Manager, server and client version are always the same, thus, stdout can be splitlined and the first part taken and passed to
ComparableScyllaVersion().In current implemented the input like
3.6.0\nServer version: 3.6.0\nis set, whichComparableScyllaVersion()somehow manages to handle but which is not technically correct.Testing: