Add integrated scylla-monitoring stack support#724
Open
dkropachev wants to merge 1 commit intomasterfrom
Open
Conversation
5 tasks
9392bad to
1226411
Compare
1226411 to
5c80573
Compare
Contributor
Author
|
@fruch , now it is ready and tested, the only reason why |
Spin up a Prometheus + Grafana + Alertmanager stack alongside any CCM cluster using Docker containers with --net=host. Automatic mode (--monitoring or CCM_MONITORING=1) keeps Prometheus scrape targets in sync on every topology change. Manual mode (ccm monitoring start/stop/sync) gives on-demand control. Multi-cluster setups are supported via port offsets based on cluster ID. When scylla-monitoring repo is available, real dashboards are generated; otherwise a built-in fallback overview dashboard is used. New CLI: ccm create ... --monitoring [--monitoring-dir=PATH] ccm monitoring start|stop|enable|disable|sync|status
5c80573 to
4378b81
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add first-class monitoring integration to CCM: a Prometheus + Grafana + Alertmanager
stack that runs alongside any Scylla cluster as Docker containers with
--net=host.Two modes of operation:
--monitoringflag orCCM_MONITORING=1env var) — monitoringstarts with the cluster and Prometheus scrape targets are kept in sync on every
topology change (add, remove, start, stop, decommission).
ccm monitoring start/stop/sync) — on-demand control, no automatictarget updates.
Key features:
simultaneously
scylla-monitoringrepo for real Grafana dashboards; falls back to abuilt-in overview dashboard when unavailable
operations
cluster.confand restored on loadNew CLI surface:
Changed files
ccmlib/scylla_monitoring.py— newMonitoringStackclassccmlib/cmds/cluster_cmds.py—ClusterMonitoringCmd+--monitoringflag on createccmlib/cluster.py— monitoring fields,_notify_topology_change()hookccmlib/scylla_cluster.py— auto-start/stop monitoring,CCM_MONITORINGenv varccmlib/scylla_node.py,ccmlib/node.py— topology change notificationsccmlib/cluster_factory.py— restore monitoring settings on loaddocs/monitoring.md— full reference documentationREADME.md— monitoring section, environment variables tabletests/test_scylla_monitoring.py— unit tests for MonitoringStacktests/test_monitoring_integration.py— integration tests for CLI and hooks