Backport gemini to 2024.1 #10416
Open
Backport gemini to 2024.1 #10416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dockerfile has been moved to gemini project, and now SCT should use that image. Changes: - Use image from scylladb/gemini - Remove dockerfile for gemini and point in readme location for the images - Add CQL Statement Logging to gemini output - Forward outputs from docker to $HOME/*.log - Run default gemini flags from gemini_thread.py Signed-off-by: Dusan Malusev <[email protected]>
When gemini_thread.py was refactored, every command in test-cases/gemini was refactored to use the new model of declaring the flags. But it was not anticipated that there were more places where gemini was used e.g. test-cases/cdc and test-cases/upgrades Signed-off-by: Dusan Malusev <[email protected]>
Signed-off-by: Dusan Malusev <[email protected]>
CodeLieutenant
added
backport/none
fruch
requested changes
Mar 17, 2025
CodeLieutenant
force-pushed
the
backport-gemini-2024-1
branch
2 times, most recently
from
dad7628 to
abebdb1
Compare
Signed-off-by: Dusan Malusev <[email protected]>
CodeLieutenant
force-pushed
the
backport-gemini-2024-1
branch
from
abebdb1 to
6a45dde
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backporting gemini fixes to 2024.1 from master branch
Testing
PR pre-checks (self review)
backportlabelsReminders
sdcm/sct_config.py)unit-test/folder)