fix(sdcm/cluster.py): Use microdnf on rhel-like docker backend #10487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k0machi
added
backport/2024.2
|
Testing the change is blocked by #10480 |
k0machi
force-pushed
the
fix-use-microdnf-for-ubi9-sd
branch
2 times, most recently
from
af93ad3 to
7aa1699
Compare
fruch
force-pushed
the
fix-use-microdnf-for-ubi9-sd
branch
from
7aa1699 to
e63c156
Compare
|
meanwhile I've decided to disable it in #10491, and backport to all releases. once we'll have the fixes in place, we can enable it back |
k0machi
force-pushed
the
fix-use-microdnf-for-ubi9-sd
branch
4 times, most recently
from
10d8eb5 to
a4e2499
Compare
soyacz
reviewed
Mar 28, 2025
| if self.node.parent_cluster.cluster_backend == "docker": | ||
| self.log.info("Scylla Doctor check in SCT isn't yet support for docker backend") | ||
| return | ||
| # if self.node.parent_cluster.cluster_backend == "docker": |
| @@ -1871,7 +1871,10 @@ def install_package(self, | |||
| package_version: str = None, | |||
| ignore_status: bool = False) -> None: | |||
| if self.distro.is_rhel_like: | |||
| pkg_cmd = 'yum' | |||
| if not self.parent_cluster.cluster_backend == "docker": | |||
There was a problem hiding this comment.
@fruch shouldn't we also adjust code for k8s to support rhel? (it's not just this one, so can be done in followup)
There was a problem hiding this comment.
It can be a followup
Anyhow we should minimize the usage of it as much as possible
Since we are now using RHEL UBI9 image for our docker backend, add additional logic to support using `microdnf` inside BaseNode.install_package Fixes scylladb#10449
k0machi
force-pushed
the
fix-use-microdnf-for-ubi9-sd
branch
from
a4e2499 to
9b56a7a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we are now using RHEL UBI9 image for our docker backend, add
additional logic to support using
microdnfinsideBaseNode.install_package
Fixes #10449
Testing
PR pre-checks (self review)
backportlabelsReminders
sdcm/sct_config.py)unit-test/folder)