Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(gemini): run latest gemini version as Tier 1 testing tool #10495

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

CodeLieutenant
Copy link
Contributor

Testing

  • [ ]

PR pre-checks (self review)

  • I added the relevant backport labels
  • I didn't leave commented-out/debugging code

Reminders

  • Add New configuration option and document them (in sdcm/sct_config.py)
  • Add unit tests to cover my changes (under unit-test/ folder)
  • Update the Readme/doc folder relevant to this change (if needed)

@CodeLieutenant CodeLieutenant added test-integration Enable running the integration tests suite backport/2025.1 labels Mar 25, 2025
@CodeLieutenant CodeLieutenant self-assigned this Mar 25, 2025
@CodeLieutenant CodeLieutenant requested a review from fruch March 25, 2025 11:25
@pehala
Copy link
Contributor

pehala commented Mar 25, 2025

I dont understand how this PR makes it a Tier 1 testing tool, wouldnt that change be at scylla-pkg level?

@fruch
Copy link
Contributor

fruch commented Mar 25, 2025

I dont understand how this PR makes it a Tier 1 testing tool, wouldnt that change be at scylla-pkg level?

the actual trigger of tier1, is in SCT code, and should be change as part of PR as well
scylla-pkg only trigger one job/trigger per backend with AMI or other SMI like parameters.

and yes we should remove the trigger from scylla-pkg of the gemini job if there is such

test_name: 'gemini_test.GeminiTest.test_load_random_with_nemesis',
test_config: 'test-cases/gemini/gemini-1tb-10h.yaml',

timeout: [time: 1000, unit: 'MINUTES'],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this timeout can be dropped

@yarongilor
Copy link
Contributor

After a rebase, the test of test_01_gemini_thread should be adjusted.
mainly the variable of expected_gemini_arguments, with new values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/2025.1 test-integration Enable running the integration tests suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants