fix(nemesis): make nemesis more safely by adding repair on all nodes #10496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timtimb0t
requested review from
fruch,
vponomaryov,
aleksbykov,
soyacz and
temichus
timtimb0t
force-pushed
the
validation_after_destroying
branch
from
f28bb16 to
ada17ec
Compare
aleksbykov
reviewed
Mar 26, 2025
sdcm/nemesis.py
Outdated
| node.run_nodetool(sub_cmd="repair", publish_event=publish_event) | ||
| def repair_nodetool_repair(self, node=None, publish_event=True, all_nodes=False): | ||
| if all_nodes: | ||
| for node in self.cluster.nodes: |
There was a problem hiding this comment.
you can use only data nodes self.clsuter.data_nodes. Repair operation could be skipped on zero-token nodes
| node = node if node else self.target_node | ||
| with adaptive_timeout(Operations.REPAIR, node, timeout=HOUR_IN_SEC * 48): | ||
| node.run_nodetool(sub_cmd="repair", publish_event=publish_event) | ||
| def repair_nodetool_repair(self, node=None, publish_event=True, all_nodes=False): |
There was a problem hiding this comment.
i think, you need go over the method usage, and find out whether this method used in Non-disruptive nemesis(methods), so operation is not failed if node is under Disruptive nemesis. Otherwise, you need to make this changes a bit safely by adding ignore status of nodetool command or add try except
| @@ -4273,6 +4278,7 @@ def disrupt_repair_streaming_err(self): | |||
| """ | |||
| Stop repair in middle to trigger some streaming fails, then rebuild the data on the node. | |||
| """ | |||
| self.repair_nodetool_repair(all_nodes=True) | |||
There was a problem hiding this comment.
add a short comment, why we need it here
this change add repair at the beggining of disrupt_repair_streaming_err to make this nemesis more safe and avoid c-s data validation errors ref: scylladb/scylladb#21428
timtimb0t
force-pushed
the
validation_after_destroying
branch
from
ada17ec to
728a8b1
Compare
|
@timtimb0t new branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this change add repair at the beggining of disrupt_repair_streaming_err to make this nemesis more safe and avoid c-s data validation errors ref: scylladb/scylladb#21428
Testing
PR pre-checks (self review)
backportlabelsReminders
sdcm/sct_config.py)unit-test/folder)