-
Notifications
You must be signed in to change notification settings - Fork 104
fix(nemesis): make nemesis more safely by adding repair on all nodes #10496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(nemesis): make nemesis more safely by adding repair on all nodes #10496
Conversation
f28bb16
to
ada17ec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need make the repair method a bit safely
ada17ec
to
728a8b1
Compare
@timtimb0t new branch |
@aleksbykov , could you please take a look again? |
728a8b1
to
75c38aa
Compare
75c38aa
to
b56f6ba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to fix it, because we broke behavior of this method
2ca2f1d
to
205c7cc
Compare
205c7cc
to
619cfb0
Compare
Here https://github.com/timtimb0t/scylla-cluster-tests/blob/619cfb05b0c5bc8126401ef95945f7b7a65cddac/sdcm/nemesis.py#L3629 same code is used, you can replace it with your method. And add please docstring with description why we skip repair error |
619cfb0
to
d8b03a0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add documentation
@timtimb0t new branch |
@scylladb/qa-maintainers , could you please merge? |
@timtimb0t , please add link to job with fix where the code was executed |
4962ede
to
96acfa2
Compare
96acfa2
to
2c2f1a2
Compare
2c2f1a2
to
264d957
Compare
the original referenced bug talks about but this PR doesn't do anything with that nemesis, so I'm a bit confused |
it was decided to place fix before the nemesis that failed (ie disrupt_repair_streaming_err) because it failed few times with the same error |
Just add the -pr for now, it's a path we probably won't exercise but better to be on the safe side. |
this change add repair at the beggining of disrupt_repair_streaming_err to make this nemesis more safe and avoid c-s data validation errors ref: scylladb/scylladb#21428
264d957
to
37825f9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
this change add repair at the beggining of disrupt_repair_streaming_err to make this nemesis more safe and avoid c-s data validation errors ref: scylladb/scylladb#21428
fixes: scylladb/scylladb#21428
Testing
https://jenkins.scylladb.com/job/scylla-staging/job/eugene_test_folder/job/repair_repair/6/
PR pre-checks (self review)
backport
labelsReminders
sdcm/sct_config.py
)unit-test/
folder)