Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement(scylla-bench): report scylla-bench version info in logs #10505

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dimakr
Copy link
Contributor

@dimakr dimakr commented Mar 26, 2025

The change implements scylla-bench and scylla-go-cql driver versions reporter.

Closes: https://github.com/scylladb/qa-tasks/issues/1877

Testing

  • 🟠 pr-provision-test
    The test run failed on cassandra-stress load, but it doesn't related to this change. The s-b version is collected and reported to logs by the new ScyllaBenchVersionReporter as:
21:23:45  < t:2025-03-26 20:23:42,069 f:tooling_reporter.py l:122  c:sdcm.reporting.tooling_reporter p:INFO  > ScyllaBenchVersionReporter(): Collected scylla-bench version output:
21:23:45  < t:2025-03-26 20:23:42,069 f:tooling_reporter.py l:122  c:sdcm.reporting.tooling_reporter p:INFO  > {
21:23:45  < t:2025-03-26 20:23:42,069 f:tooling_reporter.py l:122  c:sdcm.reporting.tooling_reporter p:INFO  >   "scylla-bench": {
21:23:45  < t:2025-03-26 20:23:42,069 f:tooling_reporter.py l:122  c:sdcm.reporting.tooling_reporter p:INFO  >     "version": "v0.2.0",
21:23:45  < t:2025-03-26 20:23:42,069 f:tooling_reporter.py l:122  c:sdcm.reporting.tooling_reporter p:INFO  >     "commit_date": "unknown",
21:23:45  < t:2025-03-26 20:23:42,069 f:tooling_reporter.py l:122  c:sdcm.reporting.tooling_reporter p:INFO  >     "commit_sha": "unknown"
21:23:45  < t:2025-03-26 20:23:42,069 f:tooling_reporter.py l:122  c:sdcm.reporting.tooling_reporter p:INFO  >   },
21:23:45  < t:2025-03-26 20:23:42,069 f:tooling_reporter.py l:122  c:sdcm.reporting.tooling_reporter p:INFO  >   "scylla-driver": {
21:23:45  < t:2025-03-26 20:23:42,069 f:tooling_reporter.py l:122  c:sdcm.reporting.tooling_reporter p:INFO  >     "version": "v1.14.5",
21:23:45  < t:2025-03-26 20:23:42,069 f:tooling_reporter.py l:122  c:sdcm.reporting.tooling_reporter p:INFO  >     "commit_date": "unknown",
21:23:45  < t:2025-03-26 20:23:42,069 f:tooling_reporter.py l:122  c:sdcm.reporting.tooling_reporter p:INFO  >     "commit_sha": "unknown"
21:23:45  < t:2025-03-26 20:23:42,069 f:tooling_reporter.py l:122  c:sdcm.reporting.tooling_reporter p:INFO  >   }
21:23:45  < t:2025-03-26 20:23:42,069 f:tooling_reporter.py l:122  c:sdcm.reporting.tooling_reporter p:INFO  > }
21:23:45  < t:2025-03-26 20:23:42,070 f:tooling_reporter.py l:36   c:sdcm.reporting.tooling_reporter p:INFO  > ScyllaBenchVersionReporter(): scylla-bench version is v0.2.0

For some reason the commit details were not collected when building the 0.2.0 release binary (perhaps the new s-b release CI affected how the commit details are collected).
But this should be investigated and fixed in the scylla-bench itself.

PR pre-checks (self review)

  • I added the relevant backport labels
  • I didn't leave commented-out/debugging code

Reminders

  • Add New configuration option and document them (in sdcm/sct_config.py)
  • Add unit tests to cover my changes (under unit-test/ folder)
  • Update the Readme/doc folder relevant to this change (if needed)

The change implements scylla-bench and scylla-go-cql driver versions
reporter.

Closes: scylladb/qa-tasks#1877
@dimakr dimakr self-assigned this Mar 26, 2025
@dimakr
Copy link
Contributor Author

dimakr commented Mar 26, 2025

This change is put on-hold until scylladb/scylla-bench#168 s-b issue is resolved and 0.2.0 or newer version can be used.

@soyacz
Copy link
Contributor

soyacz commented Mar 27, 2025

@dimakr let's log it into Argus. It happened I work around this topic also with cql-stress and you can see my approach (still need to supply more data to Argus, but it's a good start): #10504

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants