Skip to content

[Backport 6.2] fix(artifacts_test): Skip IOTuneValidator on unsupported instances #10511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
scylladbbot wants to merge 1 commit into from
Closed

[Backport 6.2] fix(artifacts_test): Skip IOTuneValidator on unsupported instances #10511

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 44 additions & 0 deletions artifacts_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
import typing
from functools import cached_property
import json
from unittest import SkipTest

import yaml
import requests
Expand Down Expand Up @@ -324,6 +325,49 @@ def test_scylla_service(self):
with self.subTest("check ENA support"):
assert self.node.ena_support, "ENA support is not enabled"

<<<<<<< HEAD
||||||| parent of 11409ec1a (fix(artifacts_test): Skip IOTuneValidator on unsupported instances)
if backend in ["gce", "aws", "azure"] and self.params.get("use_preinstalled_scylla"):
with self.subTest("check Scylla IO Params"):
try:
validator = IOTuneValidator(self.node)
validator.validate()
send_iotune_results_to_argus(
self.test_config.argus_client(),
validator.results,
self.node,
self.params
)
except Exception: # pylint: disable=broad-except # noqa: BLE001
self.log.error("IOTuneValidator failed", exc_info=True)
TestFrameworkEvent(source={self.__class__.__name__},
message="Error during IOTune params validation.",
severity=Severity.ERROR).publish()

=======
if backend in ["gce", "aws", "azure"] and self.params.get("use_preinstalled_scylla"):
with self.subTest("check Scylla IO Params"):
try:
if self.node.db_node_instance_type in ["t3.micro"]:
self.skipTest(
f"{self.node.db_node_instance_type} is not a supported instance - skipping this test.")
validator = IOTuneValidator(self.node)
validator.validate()
send_iotune_results_to_argus(
self.test_config.argus_client(),
validator.results,
self.node,
self.params
)
except SkipTest as exc:
self.log.info("Skipping IOTuneValidation due to %s", exc.args)
except Exception: # pylint: disable=broad-except # noqa: BLE001
self.log.error("IOTuneValidator failed", exc_info=True)
TestFrameworkEvent(source={self.__class__.__name__},
message="Error during IOTune params validation.",
severity=Severity.ERROR).publish()

>>>>>>> 11409ec1a (fix(artifacts_test): Skip IOTuneValidator on unsupported instances)
with self.subTest("verify write cache for NVMe devices"):
self.verify_nvme_write_cache()

Expand Down