test(collect_diagnosis_data_test): Add ScyllaDiagnosisReport nemesis #10536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Argus reports success but jenkins job reports failure. Will fix and remove draft tag from this |
Lakshmipathi
force-pushed
the
wip/diagnosis_data
branch
2 times, most recently
from
f8d7089 to
3efbff8
Compare
soyacz
reviewed
Mar 31, 2025
Comment on lines
+1759
to
+1762
| def disrupt_sigquit_scylla(self): | ||
| stress_cmd = self.tester.params.get('stress_cmd') | ||
| self.tester.run_stress_thread( | ||
| stress_cmd=stress_cmd, stress_num=1, stats_aggregate_cmds=False) |
There was a problem hiding this comment.
nemesis rather don't run stress_cmd - unless it is by specific design (like doubling load)
There was a problem hiding this comment.
ok, will move it outside nemesis.
| from sdcm import nemesis | ||
|
|
||
|
|
||
| class ScyllaDiagnosisReport(ClusterTester): |
There was a problem hiding this comment.
usually we don't add new tests - only in specific cases.
For this should utilize 'individual nemesis' case
Lakshmipathi
force-pushed
the
wip/diagnosis_data
branch
2 times, most recently
from
1a1acc7 to
3366de7
Compare
Adds a new ScyllaDiagnosisReport nemesis to send signal to scylladb to dump diagnostics and verify it. Fixes: scylladb#9443 Signed-off-by: Lakshmipathi.Ganapathi <[email protected]>
Lakshmipathi
force-pushed
the
wip/diagnosis_data
branch
from
3366de7 to
3fe026d
Compare
Lakshmipathi
changed the title
soyacz
reviewed
Apr 2, 2025
| @@ -703,6 +703,18 @@ def _kill_scylla_daemon(self): | |||
| self.target_node.wait_jmx_up() | |||
| self.cluster.wait_for_schema_agreement() | |||
|
|
|||
| def _sigquit_scylla_daemon(self): | |||
There was a problem hiding this comment.
btw. we have already generate_coredump_file method in BaseNode class - this could reuse your new method and print diagnosis dump.
Also add node log message with DbNodeLogger about this signal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new ScyllaDiagnosisReport nemesis to send signal to scylladb to dump diagnostics and verify it.
Fixes: #9443
Testing
PR pre-checks (self review)
backportlabelsReminders
sdcm/sct_config.py)unit-test/folder)