Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(performance): change error threshold for steps test #10606

Merged

Conversation

juliayakovlev
Copy link
Contributor

Following discussions with Roy, the P99 read error threshold will be increased for steps 600K and 700K in both vnode and tablet tests.

Testing

  • [ ]

PR pre-checks (self review)

  • I added the relevant backport labels
  • I didn't leave commented-out/debugging code

Reminders

  • Add New configuration option and document them (in sdcm/sct_config.py)
  • Add unit tests to cover my changes (under unit-test/ folder)
  • Update the Readme/doc folder relevant to this change (if needed)

Following discussions with Roy, the P99 read error threshold will be
increased for steps 600K and 700K in both vnode and tablet tests.
@soyacz
Copy link
Contributor

soyacz commented Apr 7, 2025

how about #9887?

@juliayakovlev
Copy link
Contributor Author

how about #9887?

@soyacz
Ah, I missed it .
@roydahan looks like this commit should be closed.
do you approve #9887?

@roydahan
Copy link
Contributor

roydahan commented Apr 7, 2025

I didn't go over all results that are part of the changes in #9887.
I prefer to do it in small steps like here and merge this one for now.

@soyacz soyacz merged commit cf4607a into scylladb:master Apr 8, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants