Skip to content

improvement(performance): change c-s version to 3.17.5 #10620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −3
Open

improvement(performance): change c-s version to 3.17.5 #10620

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...n/scylla-enterprise-perf-regression-predefined-throughput-steps-write-tablets.jenkinsfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,6 @@ perfRegressionParallelPipeline(
backend: "aws",
aws_region: "us-east-1",
test_name: "performance_regression_gradual_grow_throughput.PerformanceRegressionPredefinedStepsTest",
test_config: '''["test-cases/performance/perf-regression-predefined-throughput-steps.yaml", "configurations/performance/cassandra_stress_gradual_load_steps_enterprise.yaml", "configurations/disable_kms.yaml", "configurations/disable_speculative_retry.yaml","configurations/perf-loaders-shard-aware-config.yaml", "configurations/performance/latency-decorator-error-thresholds-steps-ent-tablets.yaml"]''',
test_config: '''["test-cases/performance/perf-regression-predefined-throughput-steps.yaml", "configurations/performance/cassandra_stress_gradual_load_steps_enterprise.yaml", "configurations/disable_kms.yaml", "configurations/disable_speculative_retry.yaml", "configurations/performance/latency-decorator-error-thresholds-steps-ent-tablets.yaml"]''',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after removing this shard aware config maybe we could move write test back to read and mixed pipeline?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought this. But write test history will be missed then

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can consider copying data from one test to another so we could keep the history - shouldn't be hard - but only if you find it a valuable move.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The question is do we want to continue to keep two additional jobs. if it is not the problem, we can continue with current jobs configuration

@roydahan @fruch

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now I wouldn't bother to unify them, but as you think.
It can be also a follow-up work.

sub_tests: ["test_write_gradual_increase_load"],
)
2 changes: 1 addition & 1 deletion ...on/scylla-enterprise-perf-regression-predefined-throughput-steps-write-vnodes.jenkinsfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,6 @@ perfRegressionParallelPipeline(
backend: "aws",
aws_region: "us-east-1",
test_name: "performance_regression_gradual_grow_throughput.PerformanceRegressionPredefinedStepsTest",
test_config: '''["test-cases/performance/perf-regression-predefined-throughput-steps.yaml", "configurations/performance/cassandra_stress_gradual_load_steps_enterprise.yaml", "configurations/disable_kms.yaml", "configurations/tablets_disabled.yaml", "configurations/disable_speculative_retry.yaml","configurations/perf-loaders-shard-aware-config.yaml", "configurations/performance/latency-decorator-error-thresholds-steps-ent-vnodes.yaml"]''',
test_config: '''["test-cases/performance/perf-regression-predefined-throughput-steps.yaml", "configurations/performance/cassandra_stress_gradual_load_steps_enterprise.yaml", "configurations/disable_kms.yaml", "configurations/tablets_disabled.yaml", "configurations/disable_speculative_retry.yaml", "configurations/performance/latency-decorator-error-thresholds-steps-ent-vnodes.yaml"]''',
sub_tests: ["test_write_gradual_increase_load"],
)
2 changes: 1 addition & 1 deletion test-cases/performance/perf-regression-predefined-throughput-steps.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,4 +66,4 @@ append_scylla_yaml:
use_placement_group: true
use_prepared_loaders: false
stress_image:
cassandra-stress: 'scylladb/cassandra-stress:3.13.0'
cassandra-stress: 'scylladb/cassandra-stress:3.17.5'