Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(manager): apply dc-mapping only if restoring tables, not schema #10621

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(manager): apply dc-mapping only if restoring tables, not schema #10621

wants to merge 1 commit into from

Conversation

mikliapko
Copy link
Contributor

@mikliapko mikliapko commented Apr 10, 2025 •
edited
Loading

Manager restore operation flag --dc-mapping is applicable for tables restore mode only (docs).
Thus, should not be applied while restoring the schema.

Testing

PR pre-checks (self review)

  • I added the relevant backport labels
  • I didn't leave commented-out/debugging code

@mikliapko
fix(manager): apply dc-mapping only if restoring tables, not schema
6a42cd7 
Manager restore operation flag `--dc-mapping` is applicable for tables
restore mode only(1). Thus, should not be applied while restoring the
schema.

refs:
1. https://manager.docs.scylladb.com/stable/sctool/restore.html#dc-mapping
@mikliapko mikliapko added the backport/none Backport is not required label Apr 10, 2025
@mikliapko mikliapko self-assigned this Apr 10, 2025
@mikliapko mikliapko requested a review from Copilot April 10, 2025 09:47
Copilot
Copilot AI reviewed Apr 10, 2025
View reviewed changes
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

@mikliapko mikliapko marked this pull request as ready for review April 10, 2025 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@vponomaryov vponomaryov vponomaryov approved these changes

@karol-kokoszka karol-kokoszka Awaiting requested review from karol-kokoszka

@Michal-Leszczynski Michal-Leszczynski Awaiting requested review from Michal-Leszczynski

At least 2 approving reviews are required to merge this pull request.

Assignees

@mikliapko mikliapko

Labels
backport/none Backport is not required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikliapko @vponomaryov