[Backport 2025.1] fix(ScyllaYaml): replace enable_tablets with tablets_mode_for_new_keyspaces #10624
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cezarmoise - This PR has conflicts, therefore it was moved to |
…ption The configuration option was added in scylladb/scylladb#22273 It take precedence over `enable_tablets` (cherry picked from commit 452e948)
cezarmoise
force-pushed
the
backport/10614/to-2025.1
branch
from
8950170 to
d8181cd
Compare
vponomaryov
approved these changes
Apr 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The configuration option was changed in scylladb/scylladb#22273
Causing all SCT runs after it to run without tablets.
e.g. https://argus.scylladb.com/tests/scylla-cluster-tests/a50f6974-da50-4963-b7ea-bbfeac27bdca
2025.1 not affected yet, backport was yesterday.
Testing
2025.2.0~dev-20250403.fe8187e5940e, before the change, keyspace1 has tablets enabled2025.2.0~dev-20250407.8d2a41db8231, after the change, keyspace1 does not have tablets enabled2025.2.0~dev-20250407.8d2a41db8231, after the change, with this fix, keyspace1 has tablets enabledPR pre-checks (self review)
backportlabelsReminders
Add New configuration option and document them (in
sdcm/sct_config.py)Add unit tests to cover my changes (under
unit-test/folder)Update the Readme/doc folder relevant to this change (if needed)
(cherry picked from commit 452e948)
Parent PR: #10614