-
Notifications
You must be signed in to change notification settings - Fork 101
fix(docker): fix set kernel perf event paranoid set #10635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(docker): fix set kernel perf event paranoid set #10635
Conversation
When using docker and setting `print_kernel_callstack` param we need to set `kernel.perf_event_paranoid=0` - which didn't work due missing params and proper privileges for docker. refs: scylladb#10633
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
Files not reviewed (1)
- docker/scylla-sct/centos/Dockerfile: Language not supported
Comments suppressed due to low confidence (1)
sdcm/cluster_docker.py:59
- Using bool() directly on the print_kernel_callstack parameter may lead to unexpected behavior if the parameter is provided as a non-boolean value (e.g., the string 'false'). Consider converting or validating the parameter to explicitly obtain a boolean value.
privileged = bool(self.parent_cluster.params.get('print_kernel_callstack'))
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @soyacz
@lsfreitas FYI |
this is not solving the original issue, just helps with mentioned error when setting this system setting. |
@soyacz I don't think we should update the I think we should update the related SCT config option instead:
|
hmm, yes, that seems to be true. Better not change host settings.
so, I'd propose to disable it at code by adding
|
wrong approach. closing |
When using docker and setting
print_kernel_callstack
param we need to setkernel.perf_event_paranoid=0
- which didn't work due missing params and proper privileges for docker.refs: #10633
Testing
PR pre-checks (self review)
backport
labelsReminders
sdcm/sct_config.py
)unit-test/
folder)