Skip to content

improvement(sct): Do not require AWS for conf-docs and update-conf-docs #10642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 16, 2025

Conversation

pehala
Copy link
Contributor

@pehala pehala commented Apr 15, 2025

Currently, both conf-docs and update-conf-docs require AWS due to instantiation of SCTConfiguration class. Make required methods class methods to prevent unnecessary validation. This also speeds up the entire process.

Testing

  • Locally

PR pre-checks (self review)

  • I added the relevant backport labels
  • I didn't leave commented-out/debugging code

Reminders

  • Add New configuration option and document them (in sdcm/sct_config.py)
  • Add unit tests to cover my changes (under unit-test/ folder)
  • Update the Readme/doc folder relevant to this change (if needed)

@pehala pehala added the backport/none Backport is not required label Apr 15, 2025
Copy link
Contributor

@vponomaryov vponomaryov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to fix the precommit failure:

11:58:37  Currently, both conf-docs and update-conf-docs require AWS due to instantiation of SCTConfiguration class. Make required methods class methods to prevent unnecessary validation.
11:58:37  ✖   body's lines must not be longer than 120 characters [body-max-line-length]

Currently, both conf-docs and update-conf-docs
require AWS due to instantiation of
SCTConfiguration class.
Make required methods class methods to prevent
unnecessary validation.
@pehala
Copy link
Contributor Author

pehala commented Apr 16, 2025

Need to fix the precommit failure:

11:58:37  Currently, both conf-docs and update-conf-docs require AWS due to instantiation of SCTConfiguration class. Make required methods class methods to prevent unnecessary validation.
11:58:37  ✖   body's lines must not be longer than 120 characters [body-max-line-length]

Should be fixed

@vponomaryov vponomaryov requested a review from soyacz April 16, 2025 10:09
Copy link
Contributor

@soyacz soyacz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@soyacz soyacz merged commit 86783e8 into scylladb:master Apr 16, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/none Backport is not required promoted-to-master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants