[Backport 2024.2] improvement(decode_backtrace): improve logic #10737
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current logic for decoding backtrace was locking db log processing for duration of getting path to scylla debug file. Also it was downloading debug file once - possibly resulting in wrong backtrace decode in upgrade tests. Moved logic for getting debug file info to decoding queue, so it's not locking db log processing loop. Also downloading debug file to monitor node (where decoding is done) to `/tmp/debug_<build_id>` and skipping download if it's already there. closes: https://github.com/scylladb/qa-tasks/issues/57 (cherry picked from commit 7bf36b3)
soyacz
approved these changes
Apr 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current logic for decoding backtrace was locking db log processing for duration of getting path to scylla debug file. Also it was downloading debug file once - possibly resulting in wrong backtrace decode in upgrade tests.
Moved logic for getting debug file info to decoding queue, so it's not locking db log processing loop. Also downloading debug file to monitor node (where decoding is done) to
/tmp/debug_<build_id>and skipping download if it's already there.closes: https://github.com/scylladb/qa-tasks/issues/57
Testing
PR pre-checks (self review)
backportlabelsReminders
Add New configuration option and document them (in
sdcm/sct_config.py)Add unit tests to cover my changes (under
unit-test/folder)Update the Readme/doc folder relevant to this change (if needed)
(cherry picked from commit 7bf36b3)
Parent PR: #10646