[Backport 2025.1] improvement(logging): added 'actions' log #10905
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@soyacz - This PR has conflicts, therefore it was moved to |
soyacz
force-pushed
the
backport/10841/to-2025.1
branch
from
72d1b4f to
7803db2
Compare
soyacz
approved these changes
May 16, 2025
soyacz
force-pushed
the
backport/10841/to-2025.1
branch
from
7803db2 to
17faa44
Compare
Introducing `actions` log for tracking testing process: what actions SCT does to cluster. This will help to quickly find out test steps taken by SCT e.g. restarting, corrupting data, aborting etc.. It will also log all error/critical events (basic details only: event type, severity, event_id and node). This log should contain only the most important actions, not to blurry test flow with too much information. It works by appending JSON lines to `actions.log` and also to `sct.log` (in simpler, textual form). Intention of JSON lines is to be easily parsable for further visualisation, AI integration and still keeping human-readable form. This commit introduces it only in limited scope - with intention to expand it to other test cases and threads (like Nemesis, full scan thread etc.) refs: scylladb#8909 (cherry picked from commit 0576cdf)
soyacz
force-pushed
the
backport/10841/to-2025.1
branch
from
17faa44 to
c1300ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introducing
actionslog for tracking testing process: what actions SCT does to cluster. This will help to quickly find out test steps taken by SCT e.g. restarting, corrupting data, aborting etc.. It will also log all error/critical events (basic details only: event type, severity, event_id and node). This log should contain only the most important actions, not to blurry test flow with too much information.It works by appending JSON lines to
actions.logand also tosct.log(in simpler, textual form). Intention of JSON lines is to be easily parsable for further visualisation, AI integration and still keeping human-readable form.This commit introduces it only in limited scope - with intention to expand it to other test cases and threads (like Nemesis, full scan thread etc.)
refs: #8909
Testing
PR pre-checks (self review)
backportlabelsReminders
Add New configuration option and document them (in
sdcm/sct_config.py)Add unit tests to cover my changes (under
unit-test/folder)Update the Readme/doc folder relevant to this change (if needed)
(cherry picked from commit 0576cdf)
Parent PR: #10841