[Backport 2025.2] improvement(nemesis_tests): Make tests independant from production Nemesis #10957
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 40d435b)
- Move them to separate directory - Use custom subclass hierarchies to make them less dependent on the implementation - Add NemesisRegistry tests - Fixes scylladb#10592 (cherry picked from commit de7c7c5)
scylladbbot
force-pushed
the
backport/10912/to-2025.2
branch
from
42fbefe to
2bdec6d
Compare
vponomaryov
reviewed
May 27, 2025
| from unit_tests.test_tester import ClusterTesterForTests | ||
|
|
||
|
|
||
| class TestNemesisClass(Nemesis): |
There was a problem hiding this comment.
This naming makes pytest think it is test class and produce following messages:
10:28:07 collecting ... /tmp/jenkins/workspace/an_scylla-cluster-tests_PR-10957/unit_tests/nemesis/test_sisyphus.py:14: PytestCollectionWarning: cannot collect test class 'TestNemesisClass' because it has a __init__ constructor (from: nemesis/test_sisyphus.py)
10:28:07 class TestNemesisClass(Nemesis):
10:28:07 /tmp/jenkins/workspace/an_scylla-cluster-tests_PR-10957/unit_tests/nemesis/test_sisyphus.py:14: PytestCollectionWarning: cannot collect test class 'TestNemesisClass' because it has a __init__ constructor (from: nemesis/test_specific_nemesis.py)
10:28:07 class TestNemesisClass(Nemesis):
vponomaryov
approved these changes
May 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing
PR pre-checks (self review)
I added the relevant
backportlabelsI didn't leave commented-out/debugging code
(cherry picked from commit 40d435b)
(cherry picked from commit de7c7c5)
Parent PR: #10912