[Backport 2025.4] fix(nemesis): skip disrupt_refuse_connection nemesis when target is alone in rack#14976
Merged
pehala merged 1 commit intoJun 11, 2026
Conversation
…lone in rack The nemeses `disrupt_refuse_connection_with_block_scylla_ports_on_banned_node` and `disrupt_refuse_connection_with_send_sigstop_signal_to_scylla_on_banned_node` need to remove the target node at some point, and if that node is the only one in the rack, that is not allowed. Added a helper function to check if a node is alone in its rack. (cherry picked from commit c0656a6)
Contributor
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
pehala
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The nemeses
disrupt_refuse_connection_with_block_scylla_ports_on_banned_nodeand disrupt_refuse_connection_with_send_sigstop_signal_to_scylla_on_banned_node` need to remove the target node at some point, and if that node is the only one in the rack, that is not allowed.Example of failure:
https://argus.scylladb.com/tests/scylla-cluster-tests/f4267f80-cf89-4611-8d74-58f0592f33f9
Testing
PR pre-checks (self review)
backportlabelsReminders
Add New configuration option and document them (in
sdcm/sct_config.py)Add unit tests to cover my changes (under
unit-test/folder)Update the Readme/doc folder relevant to this change (if needed)
(cherry picked from commit c0656a6)
Parent PR: #13965