Skip to content

[Backport 2024.2] fix(issue_cache): add pull-requests to cache #7894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Jul 9, 2024

in some places we are using PRs and not issue to identify
if we should be skipping something in the test code

we now generate two diffrent cache files on s3 for each repository
one for the issues and one for the pull requests

client code is merging it to once local cache, so it's mentioning
of either one should be working as expect, and read from cache,
not using affecting the hourly rate-limit

Ref: https://github.com/scylladb/qa-tasks/issues/1735

Testing

  • unit tests
  • integration tests

PR pre-checks (self review)

  • I added the relevant backport labels
  • I didn't leave commented-out/debugging code

Reminders

  • Add New configuration option and document them (in sdcm/sct_config.py)
  • Add unit tests to cover my changes (under unit-test/ folder)
  • Update the Readme/doc folder relevant to this change (if needed)

(cherry picked from commit 6661e26)

(cherry picked from commit 6f4b284)

Parent PR: #7850

in some places we are using PRs and not issue to identify
if we should be skipping something in the test code

we now generate two diffrent cache files on s3 for each repository
one for the issues and one for the pull requests

client code is merging it to once local cache, so it's mentioning
of either one should be working as expect, and read from cache,
not using affecting the hourly rate-limit

Ref: scylladb/qa-tasks#1735
(cherry picked from commit 6661e26)
@mergify mergify bot assigned fruch Jul 9, 2024
@fruch fruch force-pushed the mergify/bp/branch-2024.2/pr-7850 branch from e1ea2d0 to ff7fceb Compare July 9, 2024 06:22
@fruch fruch merged commit 90db9cc into branch-2024.2 Jul 9, 2024
6 checks passed
@mergify mergify bot deleted the mergify/bp/branch-2024.2/pr-7850 branch July 9, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant