Skip to content

test(latency): enable hinted handoff-during-upgrades #8063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

temichus
Copy link
Contributor

@temichus temichus commented Jul 21, 2024

enable hinted handoff for perf-regression-latency-650gb-upgrade

Testing

PR pre-checks (self review)

  • I added the relevant backport labels
  • I didn't leave commented-out/debugging code

Reminders

  • Add New configuration option and document them (in sdcm/sct_config.py)
  • Add unit tests to cover my changes (under unit-test/ folder)
  • Update the Readme/doc folder relevant to this change (if needed)

@temichus
Copy link
Contributor Author

(latency during upgrades 650gb) - all good

image
image
image

@temichus
Copy link
Contributor Author

(latency during upgrades / tablets 650gb) - all good

image
image
image

@temichus temichus force-pushed the hinted-handoff-latency-during-upgrades branch from c0ad7e6 to 2456992 Compare July 21, 2024 08:58
@temichus temichus marked this pull request as ready for review July 21, 2024 09:03
@temichus temichus changed the title test(latency): enable hinted handoff test(latency): enable hinted handoff-during-upgrades Jul 21, 2024
@temichus temichus requested review from soyacz and fruch July 21, 2024 11:18
@soyacz
Copy link
Contributor

soyacz commented Jul 22, 2024

@temichus Is there a proof it works correctly? E.g. a picture from monitoring showing hints sent?

@temichus
Copy link
Contributor Author

temichus commented Jul 22, 2024

@temichus Is there a proof it works correctly? E.g. a picture from monitoring showing hints sent?
@soyacz
proof (latency during upgrades 650gb write test)
hydra investigate show-monitor d7a4ad8e-de0b-4530-b8d2-c0b712f58da9

image

@fruch fruch requested a review from roydahan July 24, 2024 15:54
@roydahan
Copy link
Contributor

Same as the other one.
We won't change the test while there is an ongoing investigation for regression.

enable hinted handoff for perf-regression-latency-650gb-upgrade
@temichus temichus force-pushed the hinted-handoff-latency-during-upgrades branch from 2456992 to 42529a2 Compare December 30, 2024 09:22
@temichus
Copy link
Contributor Author

temichus commented Dec 31, 2024

fresh bisect runs for hinted-handoff-latency-during-upgrades and branch-perf-v15 branches

write hinted-handoff
image

write branch-perf-v15
image

write hinted-handoff(tablets)
image

write branch-perf-v15(tablets)
image

@temichus
Copy link
Contributor Author

temichus commented Dec 31, 2024

read hinted-handoff
image

read branch-perf-v15
image

read hinted-handoff (tablets)
image

read branch-perf-v15 (tablets)
image

@temichus
Copy link
Contributor Author

temichus commented Dec 31, 2024

mixed hinted-handoff
image

mixed branch-perf-v15
image

mixed hinted-handoff(tablets)
Test id: a2218a66-b341-466a-a792-cb5c8f548b03
image

mixed branch-perf-v15(tablets)
Test id: cea1ce69-0120-4792-a4eb-90d5bdbe06d6
image

@temichus
Copy link
Contributor Author

temichus commented Jan 1, 2025

in mixed, both show bad results but hinted handoff - worst, ain 2 reruns, picture are the same
cc @piodul

@temichus temichus marked this pull request as draft March 5, 2025 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants