Auto backport - promoted-to-master label not having effect #686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please update the |
Annamikhlin
reviewed
Apr 7, 2025
.github/scripts/auto-backport.py
Outdated
| @@ -151,12 +151,12 @@ def main(): | |||
| else: | |||
| labels = [label.name for label in pr.labels] | |||
There was a problem hiding this comment.
what about to moving it also here? as you did in https://github.com/scylladb/scylla-pkg/pull/5037/?
There was a problem hiding this comment.
Yes yes, you were faster than me 😄 Done! I've also updated the commit message and description for the issue reference
lsfreitas
force-pushed
the
fix-backport-labels
branch
2 times, most recently
from
eef735d to
c8ee117
Compare
Currently adding a label backport-x.x is enough to open a backport PR. The issue is that the github action is only checking for backport labels while the script if we have args.pull_request will ignore completely this label again. With this fix I'm setting the check for labels including the promoted_label outside of the else statement. This way the script will always check it. Refs: scylladb/scylla-pkg#4979
lsfreitas
force-pushed
the
fix-backport-labels
branch
from
c8ee117 to
f1b9fdc
Compare
yaronkaikov
approved these changes
Apr 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently adding a label backport-x.x is enough to open a backport PR.
The issue is that the github action is only checking for backport labels while the script if we have args.pull_request will ignore completely this label again.
With this fix I'm setting the check for labels including the promoted_label outside of the else statement. This way the script will always check it.
Refs: scylladb#4979