Update tested scylla versions #4340
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Michal-Leszczynski
force-pushed
the
ml/update-tested-scylla-versions
branch
5 times, most recently
from
72c152f to
23e13d1
Compare
Scylla 6.2 and 2023.1 are no longer supported by SM 3.5. Other Scylla versions have been bumped to the newest patch. Scylla nightly has returned, so that we can find issues faster.
go run main.go
Michal-Leszczynski
force-pushed
the
ml/update-tested-scylla-versions
branch
5 times, most recently
from
fb7c558 to
6dd55a3
Compare
…ablets When SM uses tablet repair API, Scylla registers a request to repair a tablet table. Later on, Scylla creates repair jobs for given tablets according to its own internal scheduler. Because of that, we have no guarantee that Scylla will start any repair jobs right after SM used tablet repair API. For example, they might be delayed due to a table migration/merge/split. The API for checking active repairs and killing repairs works on the repair job level, not the tablet repair API request level. Task manager API should be used for handling those requests. Fixes #4334
Mixing real and mocked repair jobs could result in spilling them to other tests.
Michal-Leszczynski
force-pushed
the
ml/update-tested-scylla-versions
branch
from
6dd55a3 to
3f6fa2f
Compare
…d repair.Target This commit tries to improve IPV6 handling by storing addr as netip.Addr instead of string. It does so mainly for scyllaclient.Ring and repair.Target and it adjusts all other required places in the code. Ref #4342
Michal-Leszczynski
force-pushed
the
ml/update-tested-scylla-versions
branch
from
3f6fa2f to
8fc2efc
Compare
Michal-Leszczynski
requested review from
karol-kokoszka and
VAveryanov8
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates tested Scylla versions and also changes tested configurations.
Among other things, it started testing 2025.1 with tablets and IPV6.
This combination discovered a problem with IPV6 parsing, so this PR also partially deals with #4342, but it does not fixes it completely. It also addresses some flakiness in the tests (see commit descriptions).
It also added a new package called util2 in place of the original util package which migrated to a separate submodule. The migration of util was a mistake, so in order not to waist time on creating multiple PRs with submodule changes and verion bumps, I decided to add new functionality, where it is supposed to be. After #4121 is fixed, util and util2 should be merged into a single package.
The failure in restore tests is caused by #4243, which needs to be addressed quickly.
Fixes #4334
Supersedes #4336.