TMP: tablet repair #4661
Draft
TMP: tablet repair #4661
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some task manager tasks are local to a given node, meaning that we need to check progress of this task on the node on which it was scheduled. Tablet repair is cluster wide, meaning that we can query any node for its progress. This commit makes it possible to not specify host when scheduling or checking progress of tablet repair.
…ient This way it can be accessed from different pkgs without importing repair pkg.
This way it can be accessed from different pkgs without importing repair pkg.
This error is non retryable, and we use it to safely skip colocated table tablet repair.
This way it can be accessed from different pkgs without importing repair pkg.
It will be used for storing progress of the new tablet repair task. This commit also runs `make generate`.
Tablet repair svc is supposed to handle tablet repair in a light weighted way. Since tablet repair works fine with topology changes on scylla side, tablet repair svc also makes sure to support it. It does not contain any vnode related bloat, which is not needed for tablets, and could cause problems with parallel topology changes.
This commit adds `sctool repair tablet` command. It also updates progress commands to work with tablet repair.
Michal-Leszczynski
force-pushed
the
ml/4644-tablet-repair
branch
from
ecb5633 to
e6dc5bc
Compare
…able_tablets enable_tablets has been deprecated in favor of tablets_mode_for_new_keyspaces. We can use both for simplicity when using the same scylla.yaml for multiple scylla versions. This allows for controlling default alternator table replication (vnode/tablets) in the same as for the CQL tables.
Michal-Leszczynski
force-pushed
the
ml/4644-tablet-repair
branch
from
e6dc5bc to
6c44467
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains complete implementation of new tablet repair command (#4644).
We need to merge those changes in a few PRs (changes to different SM submodules) - this PR uses go work as a workaround.
This PR serves as the overview of all changes and as a way of executing tests early.
Here are some visual examples:
sctool tasks
sctool progress (running)
sctool progress (done)
sctool progress --details
metrics