TMP: cleanup backup #4664
Draft
TMP: cleanup backup #4664
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aborting backup consists of stopping it and performing a cleanup. We already have the capability to stop running backup, but we lack the option to perform its cleanup without going through the whole purge stage. This commit adds the cleanup capability to backup svc. For now, it only removes SM snapshots from nodes' disk, but it can be easily extended with other features if needed. Refs #4648
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains complete implementation of new tablet repair command (#4648).
We need to merge those changes in a few PRs (changes to different SM submodules) - this PR uses go work as a workaround.
This PR serves as the overview of all changes and as a way of executing tests early.