fix(chore): Makefile to work with apple silicon #4703
Conversation
karol-kokoszka
requested review from
Michal-Leszczynski and
VAveryanov8
as code owners
Michal-Leszczynski
left a comment
Michal-Leszczynski
left a comment
There was a problem hiding this comment.
I guess that fix(chore) commit prefix is a typo?
| go install golang.org/x/tools/cmd/stress@v0.2.0 || echo "Warning: Failed to install stress" | ||
| go install github.com/pressly/sup/cmd/sup@v0.5.3 || echo "Warning: Failed to install sup" | ||
| go install github.com/go-swagger/go-swagger/cmd/swagger@v0.25.0 || echo "Warning: Failed to install swagger" | ||
| go install github.com/mikefarah/yq/v4@latest || echo "Warning: Failed to install yq" |
There was a problem hiding this comment.
I see that you bumped yq from v3.0.0-20201202084205-8846255d1c37 to latest.
Using latest is problematic when we want to backport something to older branch and execute CI for it. In some cases, go version used on this branch might be too old for the latest version of installed package. This results in failing CI. If this pkg needs to be bumped for the purposes of this PR, I would say it's better to bump it to the newest version available today, but not to the latest tag.
There was a problem hiding this comment.
But also, why is this bump needed? I thought that the problems with macos setup revolved around host network used in docker env, but this PR does not touch that at all. Is it not a problem anymore?
This PR updates Makefile so that docker env can be setup on macbook.
Please make sure that: