Stop disabled and stopped task #4737
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are 2 ways of disabling a task: - with 'sctool stop --disable' (or corresponding '/stop' API) - by updating task's 'enabled' property It makes some sense that directly modyfing 'enabled' property does not result in stopping the task, but it makes no sense that stopping and disabling the task does not stop the task. It can even be seen in the removed comment: '// current task is canceled on save no need to stop it again', which is false, that this behavior is unintended. We also execute our tests as if the code executed when calling '/stop' endpoint wasn't supposed to stop the task. This commit fixes behavior of '/stop' endpoint to always stop the task and additionally disable it if requested. To improve readability and testing, I moved the logic of disabling the task to Scheduer.StopTask method, so that the API handler can just call it, and we can just test it. Fixes #4736
Michal-Leszczynski
requested review from
VAveryanov8 and
karol-kokoszka
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are 2 ways of disabling a task:
It makes some sense that directly modyfing 'enabled' property does not result in stopping the task, but it makes no sense that stopping and disabling the task does not stop the task.
It can even be seen in the removed comment:
'// current task is canceled on save no need to stop it again', which is false, that this behavior is unintended.
We also execute our tests as if the code executed when calling '/stop' endpoint wasn't supposed to stop the task.
This commit fixes behavior of '/stop' endpoint to always stop the task and additionally disable it if requested. To improve readability and testing, I moved the logic of disabling the task to Scheduer.StopTask method, so that the API handler can just call it, and we can just test it.
Fixes #4736