Don't backup nor restore LWT state tables #4741
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Michal-Leszczynski
force-pushed
the
ml/4732-dont-backup-restore-lwt
branch
2 times, most recently
from
9e06015 to
9907a47
Compare
This commit adds helper functions for executing LWT queries on both cql and alternator tables. Moreover, it allows for more granular control over creating alternator table with vnodes or tablets. Refs #4732
It doesn't make sense to back up LWT state tables because: - we lack procedure for restoring them - they just contain paxos state needed for ongoing LWT queries - we lack synchronous snapshot of LWT state table and base table This commit ensures that such tables are filtered out during backup procedure. Refs #4732
It doesn't make sense to restore LWT state tables because: - we lack procedure for restoring them - they just contain paxos state needed for ongoing LWT queries - we lack synchronous snapshot of LWT state table and base table This commit ensures that such tables are filtered out during restore procedure. Fixes #4732
Michal-Leszczynski
force-pushed
the
ml/4732-dont-backup-restore-lwt
branch
from
9907a47 to
3b8e984
Compare
Michal-Leszczynski
requested review from
VAveryanov8 and
karol-kokoszka
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR validates that LWT state tables (
system.paxosorks.tab&paxos) are not backed up nor restored.In terms of the backup, their sstables are not backed up and those tables are not a part of the manifest. We also don't store their alternator friendly schema. On the other hand, they are still a part of the
DESC SCHEMA WITH INTERNALSoutput, which is saved with backup files.In terms of restore, their schema is not restored for alternator nor cql. Their sstables are also not restored, even if for some reason they ended up with the backup files.
The rationale for this change can be found in #4732, but most importantly:
system.paxostable, which either way wasn't backed up nor restoredFixes #4732