Preserve cron timezone on task reschedule #4745
Open
+57
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This problem arisen from the fact that we rely on the timezone of the time passed to cron trigger for correct calculation of next activation. We might want to improve that by switching to set timezone as a part of cron specification, but this is also confusing when we take into consideration our separate timezone flag (#3818). In this case, it wasn't done for the time of initial activation kept always in UTC+0 timezone. This resulted in switching from correct timezone to UTC+0 timezone on task reschedule. Refs #3818 Fixes #4743
Michal-Leszczynski
force-pushed
the
ml/4743-correct-tz-on-reschedule
branch
from
699577d to
3c4bf98
Compare
Michal-Leszczynski
requested review from
VAveryanov8 and
karol-kokoszka
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This problem arisen from the fact that we rely
on the timezone of the time passed to cron trigger for correct calculation of next activation.
We might want to improve that by switching to set
timezone as a part of cron specification, but this is also confusing when we take into consideration
our separate timezone flag (#3818).
In this case, it wasn't done for the time of initial activation kept always in UTC+0 timezone. This resulted in switching from correct timezone to UTC+0 timezone on task reschedule.
Refs #3818
Fixes #4743