Fix AWS credentials forwarding #214
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienrf
force-pushed
the
fix-aws-tests
branch
from
384a801 to
c6589c0
Compare
The GitHub action we use in our workflow tests-aws.yml exposes the AWS credentials by setting environment variables. We copy them to the Spark containers.
julienrf
force-pushed
the
fix-aws-tests
branch
from
c6589c0 to
ef9f354
Compare
|
interesting, so then kinesis doesn't work? |
|
The test suite that uses Kinesis passed on my machine with my personal AWS credentials. I am not sure what is the difference in the GitHub actions except the credentials. But it is complicated to use those credentials outside the GitHub action (to try to reproduce locally)… |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GitHub action we use in our workflow tests-aws.yml exposes the AWS credentials by setting environment variables. We copy them to the Spark containers.
I manually triggered the tests that access AWS. The results can be seen here: https://github.com/scylladb/scylla-migrator/actions/runs/10797896910.
Unfortunately, the tests still fail: the changes applied to the source DynamoDB table after migrating the initial snapshot are never replicated to the target ScyllaDB instance.