Skip to content

Conversation

@GeoffMontee
Copy link
Contributor

I don't know Scala. This was entirely written by Claude. We might need to fix some stuff. It's more of an intellectual exercise than a production-ready feature.

@tarzanek
Copy link
Contributor

that's why we have tests, to test what the AI might break ;-)
also with migrator tests and integrations are the worst part of the PR

@tarzanek
Copy link
Contributor

the code doesn't even build
please move to draft, get it at least building and then submit for review

Copy link
Contributor

@tarzanek tarzanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

get it at least building ...

(and then - the concept of spark dataframes and "plugins" we introduce with migrator is completely unused - just by using this we could likely remove 70% of the code in this PR)

@GeoffMontee
Copy link
Contributor Author

Hi @tarzanek ,

Maybe we could have a chat sometime to discuss design. I'm definitely not a Spark or Scala expert, so I am open to any feedback.

Thanks!

@GeoffMontee GeoffMontee marked this pull request as draft December 16, 2025 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants