-
Notifications
You must be signed in to change notification settings - Fork 181
Clean up ScyllaCluster
GET ClusterRole
#2315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up ScyllaCluster
GET ClusterRole
#2315
Conversation
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mflendrich The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test all |
/kind cleanup |
ScyllaCluster
GET ClusterRole
ScyllaCluster
GET ClusterRole
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the prefixes from the commit subject lines (explained internally, sadly we don't have the contributing guide now).
The 2nd commit subject line should also use the imperative mood - we usually name the make update
commits as Update generated
/Update autogenerated
.
Other than that it looks good to me, thanks @mflendrich
8958c82
to
e789448
Compare
@rzetelskik commits reworded, please look now |
/retest |
1 similar comment
/retest |
@mflendrich almost there, but the commit subject line should answer the following sentence |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, except commit naming as per rzetelskik comments.
/assign rzetelskik
This is simply a run of `make update` following the previous commit.
e789448
to
c2dfcbb
Compare
@rzetelskik done, please look again if this looks right. Process feedback: When a review expects rewording (of a commit message or something else), it would make my life easier (and make the review comment more actionable, and better communicate the reviewer's expectation) to see a direct wording suggestion. |
/lgtm |
Description of your changes:
Deletes the
GET
verb permission from the memberClusterRole
because Operator >=1.16 no longer needs it.Which issue is resolved by this Pull Request:
Resolves #2141