[WIP] Reconcile remote datacenters independently #2535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zimnx: GitHub didn't allow me to request PR reviews from the following users: zimnx. Note that only scylladb members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
scylla-operator-bot
bot
added
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zimnx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
scylla-operator-bot
bot
added
the
approved
zimnx
force-pushed
the
independent-datacenters
branch
from
b3235c0 to
433e060
Compare
scylla-operator-bot
bot
removed
the
needs-rebase
zimnx
force-pushed
the
independent-datacenters
branch
2 times, most recently
from
057822f to
61cac51
Compare
scylla-operator-bot
bot
added
the
needs-rebase
zimnx
force-pushed
the
independent-datacenters
branch
from
61cac51 to
110646f
Compare
scylla-operator-bot
bot
removed
the
needs-rebase
zimnx
force-pushed
the
independent-datacenters
branch
from
110646f to
f8a89a1
Compare
zimnx
force-pushed
the
independent-datacenters
branch
2 times, most recently
from
d4b239d to
978ed02
Compare
zimnx
changed the title
scylla-operator-bot
bot
removed
the
do-not-merge/work-in-progress
zimnx
added
kind/feature
scylla-operator-bot
bot
removed
do-not-merge/needs-kind
zimnx
changed the title
scylla-operator-bot
bot
added
the
do-not-merge/work-in-progress
zimnx
force-pushed
the
independent-datacenters
branch
4 times, most recently
from
d651b70 to
9519be5
Compare
zimnx
force-pushed
the
independent-datacenters
branch
4 times, most recently
from
3f3824c to
5487493
Compare
…ster during E2E tests Freamework CleanupInterface which had two responsiblities was split into Cleaner and Collect interfaces. This allows to specify custom collectors for Cluster. ScyllaDBClusters created during E2E tests now register a custom collector for each remote Cluster, collecting Namespaces originating from ScyllaDBCluster object in JustAfterEach step.
…KubernetesCluster healthcheck probes succeeds Previously aggregated Available condition was set to True when there was no ClientHealthcheckControllerAvailable having False status. When access to Kubernetes is broken and then restore, nothing removed this failed condition, hence RemoteKubernetesCluster was constantly not Available. To fix that, healthcheck controller sets this condition according to state of given healthcheck iteration.
Refactors ScyllaDBCluster controller to reconcile each datacenter independenly. Errors or connection issues of down datacenter no longer affects reconcilation of other datacenter.
…center Existing Controller Conditions were changed to represent status of reconcilation of particular Datacenter. On top of these, aggregated per Datacenter Conditions were added.
Test verifies if Operator is able to reconcile healthy datacenters when any is down, and whether it fully reconciles the cluster when down DC is restored.
zimnx
force-pushed
the
independent-datacenters
branch
from
5487493 to
15fbeb0
Compare
|
@zimnx: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors ScyllaDBCluster controller to reconcile each datacenter independenly.
Errors or connection issues of down datacenter no longer affects reconcilation of other datacenter.
Requires:
Fixes #2494