Disabled XFS rmapbt and reflink flags for reducing overhead

pkg/api/scylla/v1alpha1/types_nodeconfig.go

@@ -177,6 +177,10 @@ type FilesystemConfiguration struct {
 
 	// type is a desired filesystem type.
 	Type FilesystemType `json:"type"`
+
+	// flags contains filesystem-specific flags to be used during filesystem creation
+	// +optional
+	Flags []string `json:"flags,omitempty"`
 }
 
 // MountConfiguration specifies mount configuration options.

pkg/controller/nodesetup/sync_filesystems.go

@@ -35,7 +35,13 @@ func (nsc *Controller) syncFilesystems(ctx context.Context, nc *scyllav1alpha1.N
 			continue
 		}
 
-		changed, err := disks.MakeFS(ctx, nsc.executor, device, blockSize, string(fs.Type))
+		// Add default flags for XFS filesystem
+		flags := fs.Flags
+		if fs.Type == scyllav1alpha1.XFSFilesystem {
+			flags = append(flags, "rmapbt=0", "reflink=0")
+		}
+
+		changed, err := disks.MakeFS(ctx, nsc.executor, device, blockSize, string(fs.Type), flags)
 		if err != nil {
 			nsc.eventRecorder.Eventf(
 				nc,

pkg/disks/fs.go

@@ -12,7 +12,7 @@ import (
 	"k8s.io/utils/exec"
 )
 
-func MakeFS(ctx context.Context, executor exec.Interface, device string, blockSize int, fsType string) (bool, error) {
+func MakeFS(ctx context.Context, executor exec.Interface, device string, blockSize int, fsType string, xfsFlags []string) (bool, error) {
 	existingFs, err := blkutils.GetFilesystemType(ctx, executor, device)
 	if err != nil {
 		return false, fmt.Errorf("can't determine existing filesystem type at %q: %w", device, err)
@@ -35,8 +35,16 @@ func MakeFS(ctx context.Context, executor exec.Interface, device string, blockSi
 		"-b", fmt.Sprintf("size=%d", blockSize),
 		// no discard
 		"-K",
-		device,
 	}
+
+	// Add XFS-specific flags if filesystem type is xfs
+	if fsType == "xfs" {
+		for _, flag := range xfsFlags {
+			args = append(args, "-m", flag)
+		}
+	}
+
+	args = append(args, device)
 	stdout, stderr, err := oexec.RunCommand(ctx, executor, "mkfs", args...)
 	if err != nil {
 		return false, fmt.Errorf("can't run mkfs with args %v: %w, stdout: %q, stderr: %q", args, err, stdout.String(), stderr.String())

pkg/disks/fs_test.go

@@ -19,6 +19,7 @@ func TestMakeFS(t *testing.T) {
 		device           string
 		blockSize        int
 		fsType           string
+		flags            []string
 		expectedCommands []exectest.Command
 		expectedFinished bool
 		expectedErr      error
@@ -81,6 +82,31 @@ func TestMakeFS(t *testing.T) {
 			expectedFinished: true,
 			expectedErr:      nil,
 		},
+		{
+			name:      "format the device with default XFS flags",
+			device:    "/dev/md0",
+			blockSize: 1024,
+			fsType:    "xfs",
+			flags:     []string{"rmapbt=0", "reflink=0"},
+			expectedCommands: []exectest.Command{
+				{
+					Cmd:    "lsblk",
+					Args:   []string{"--json", "--nodeps", "--paths", "--fs", "--output=NAME,MODEL,FSTYPE,PARTUUID", "/dev/md0"},
+					Stdout: []byte(`{"blockdevices":[{"name":"/dev/md0","model":"Amazon EC2 NVMe Instance Storage","fstype":"","partuuid":"1bbeb48b-101f-4d49-8ba4-67adc9878721"}]}`),
+					Stderr: nil,
+					Err:    nil,
+				},
+				{
+					Cmd:    "mkfs",
+					Args:   []string{"-t", "xfs", "-b", "size=1024", "-K", "-m", "rmapbt=0", "-m", "reflink=0", "/dev/md0"},
+					Stdout: nil,
+					Stderr: nil,
+					Err:    nil,
+				},
+			},
+			expectedFinished: true,
+			expectedErr:      nil,
+		},
 	}
 
 	for _, tc := range tt {
@@ -92,7 +118,7 @@ func TestMakeFS(t *testing.T) {
 
 			executor := exectest.NewFakeExec(tc.expectedCommands...)
 
-			finished, err := MakeFS(ctx, executor, tc.device, tc.blockSize, tc.fsType)
+			finished, err := MakeFS(ctx, executor, tc.device, tc.blockSize, tc.fsType, tc.flags)
 			if !reflect.DeepEqual(err, tc.expectedErr) {
 				t.Fatalf("expected %v error, got %v", tc.expectedErr, err)
 			}