Skip to content

Remove redundant wait for webhook CA secret in docs' GitOps installation steps #2569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

rzetelskik
Copy link
Member

Description of your changes:
@nopzdk found that our GitOps installation steps have a redundant wait for webhook CA in prometheus-operator and scylla-operator installation instructions. This PR removes the redundant commands.

Which issue is resolved by this Pull Request:
Resolves #

/cc @mflendrich
/kind documentation
/priority important-longterm

@scylla-operator-bot scylla-operator-bot bot requested a review from mflendrich April 4, 2025 14:30
@scylla-operator-bot scylla-operator-bot bot added kind/documentation Categorizes issue or PR as related to documentation. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 4, 2025
Copy link
Collaborator

@zimnx zimnx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@scylla-operator-bot scylla-operator-bot bot added the lgtm Indicates that a PR is ready to be merged. label Apr 8, 2025
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rzetelskik, zimnx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@scylla-operator-bot scylla-operator-bot bot merged commit c132101 into scylladb:master Apr 8, 2025
9 checks passed
@rzetelskik rzetelskik deleted the remove-reduntant-docs-gitopts-steps branch April 8, 2025 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants