Skip to content

Changed the source of the ScyllaDBVersion parameter value in scyllacluster_replace test #2578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Changed the source of the ScyllaDBVersion parameter value in scyllacluster_replace test #2578

wants to merge 1 commit into from

Conversation

grzywin
Copy link
Contributor

@grzywin grzywin commented Apr 9, 2025

Description of your changes:
Fixes a missing update to ScyllaDBVersion after commit b2d7fb1, which made ScyllaDB and Scylla Manager flags configurable.

@scylla-operator-bot scylla-operator-bot bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Apr 9, 2025
@grzywin grzywin added the kind/bug Categorizes issue or PR as related to a bug. label Apr 9, 2025
@scylla-operator-bot scylla-operator-bot bot removed the do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. label Apr 9, 2025
@grzywin grzywin added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Apr 9, 2025
@scylla-operator-bot scylla-operator-bot bot removed the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Apr 9, 2025
@grzywin
Copy link
Contributor Author

grzywin commented Apr 9, 2025

/retest

1 similar comment
@grzywin
Copy link
Contributor Author

grzywin commented Apr 9, 2025

/retest

mflendrich
mflendrich approved these changes Apr 9, 2025
View reviewed changes
Copy link
Collaborator

@mflendrich mflendrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@scylla-operator-bot scylla-operator-bot bot added the lgtm Indicates that a PR is ready to be merged. label Apr 9, 2025
@scylla-operator-bot scylla-operator-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: grzywin, mflendrich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@scylla-operator-bot scylla-operator-bot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 9, 2025
@grzywin
Copy link
Contributor Author

grzywin commented Apr 14, 2025

/retest

1 similar comment
@grzywin
Copy link
Contributor Author

grzywin commented Apr 17, 2025

/retest

@scylla-operator-bot scylla-operator-bot
Copy link
Contributor

@grzywin: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gke-parallel-clusterip b2f745d link true /test e2e-gke-parallel-clusterip

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mflendrich mflendrich mflendrich approved these changes

@rzetelskik rzetelskik Awaiting requested review from rzetelskik

@zimnx zimnx Awaiting requested review from zimnx

Assignees

@mflendrich mflendrich

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grzywin @mflendrich