Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hackathon schema agreement #1248

Open
wants to merge 3 commits into
base: branch-hackathon
Choose a base branch
from
Open

Hackathon schema agreement #1248

wants to merge 3 commits into from

Conversation

soyacz
Copy link

@soyacz soyacz commented Feb 14, 2025 •
edited
Loading

Introduced 3 tests for schema agreement. based on 3 nodes cluster. Scenarios:

  1. all nodes up and normal, schema agreement should be ok
  2. one node is stopped, schema agreement should be ok
  3. one node is paused (not responding), schema agreement should be ok

3rd scenario currently fails due issue #1240

Pre-review checklist

  • I have split my patch into logically separate commits.
  • All commit messages clearly explain what they change and why.
  • I added relevant tests for new features and bug fixes.
  • All commits compile, pass static checks and pass test.
  • PR description sums up the changes and reasons why they should be introduced.
  • I have provided docstrings for the public items that I want to introduce.
  • I have adjusted the documentation in ./docs/source/.
  • I added appropriate Fixes: annotations to PR description.

@soyacz
test(schema_agreement): added ccm based test for schema agreement
c91c895 
Tested scenarios (positive: schema agreement is ok):
1. when all nodes up
2. when one node is stopped
3. when one node is paused (looks like disconnected)
@soyacz
added load balancing policy to schema agreement test with paused node
57a17f5 
to avoid querying paused node directly.
@soyacz
combined schema agreement tests to one
23cb350 
This way we save resources (less nodes) but prolong test duration (from
70 seconds to 90s, where 60s is lost on waiting for timeout in failing
 test)
@github-actions GitHub Actions
Copy link

cargo semver-checks found no API-breaking changes in this PR! 🎉🥳
Checked commit: 23cb350

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lorak-mmk Lorak-mmk Awaiting requested review from Lorak-mmk

@wprzytula wprzytula Awaiting requested review from wprzytula

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@soyacz