CI: Fix warnings in serverless tests #1316
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Lorak-mmk
force-pushed
the
scylla_cloud_tests_no_warnings
branch
2 times, most recently
from
2bf5b5f to
7159433
Compare
When serverless tests are executed, some test that are not compatible with serverless are skipped. Skipping was done by cfg-ing them out. This caused some imports to be unused which of course resulted in warnings. Github, in coordination with `setup-rust-toolchain` action, "helpfully" attached info about those warnings in EVERY COMMIT OF EVERY PR in a section "Unchanged files with check annotations" which despite being a "preview" feature has no good way of being disabled. This commit fixes that by changing `#[cfg(not(scylla_cloud_tests))]` to `#[cfg_attr(scylla_cloud_tests, ignore)]`. This causes those tests to still be compiled, just not executed. The above uncovered two real warnings about unused imports, which I also fixed.
wprzytula
approved these changes
Apr 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When serverless tests are executed, some test that are not compatible with serverless are skipped. Skipping was done by cfg-ing them out. This caused some imports to be unused which of course resulted in warnings. Github, in coordination with
setup-rust-toolchainaction, "helpfully" attached info about those warnings in EVERY COMMIT OF EVERY PR in a section "Unchanged files with check annotations" which despite being a "preview" feature has no good way of being disabled.This commit fixes that by changing
#[cfg(not(scylla_cloud_tests))]to#[cfg_attr(scylla_cloud_tests, ignore)]. This causes those tests to still be compiled, just not executed.The above uncovered two real warnings about unused imports, which I also fixed.
Pre-review checklist
!I added relevant tests for new features and bug fixes.I have provided docstrings for the public items that I want to introduce.I have adjusted the documentation in./docs/source/.I added appropriateFixes:annotations to PR description.