build: fix CMAKE_REQUIRED_FLAGS format for sanitizer detection #2724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use space-delimited string instead of semicolon-separated list for `CMAKE_REQUIRED_FLAGS` as specified in the CheckCXXSourceCompiles documentation. This fixes sanitizer detection by correctly passing compiler flags when checking for sanitizer support. Previously, we incorrectly converted a space-delimited string to a semicolon-list by replacing spaces in `Sanitizers_COMPILE_OPTIONS`, preventing proper detection of combined sanitizer configurations. Reference: https://cmake.org/cmake/help/latest/module/CheckCXXSourceCompiles.html Signed-off-by: Kefu Chai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use space-delimited string instead of semicolon-separated list for
CMAKE_REQUIRED_FLAGSas specified in the CheckCXXSourceCompiles documentation. This fixes sanitizer detection by correctly passing compiler flags when checking for sanitizer support.Previously, we incorrectly converted a space-delimited string to a semicolon-list by replacing spaces in
Sanitizers_COMPILE_OPTIONS, preventing proper detection of combined sanitizer configurations.Reference: https://cmake.org/cmake/help/latest/module/CheckCXXSourceCompiles.html