test: Add accept() vs accept_abort() socket test #3171
Conversation
When server socket sleeps in .accept() method, it should be possible to abort the waiting. The accept() should then resolve into exception of known type and error code. refs scylladb#578 Signed-off-by: Pavel Emelyanov <xemul@scylladb.com>
| auto f = ss.accept().then([] (auto ar) { | ||
| BOOST_FAIL("Accept didn't resolve into exception"); | ||
| }).handle_exception_type([&too_late] (std::system_error e) { | ||
| BOOST_REQUIRE(!too_late); |
There was a problem hiding this comment.
Please change to a coroutine or thread, they're so much more readable.
nyh
left a comment
nyh
left a comment
There was a problem hiding this comment.
Looks good, but there's something I don't understand: #578, which you "refs", claimed there is a bug in this area. Are you saying that your test proves there is no such bug, and the issue was invalid (you closed it as "completed" but I guess you meant "wontfix"?)?
Yes, I ran this test with all 3 backends and it all passed. We cannot yet make this check run all the time, as test.py runs tests with "most suitable" backend once, and individual tests can request for some specific backend (like socket_test explicitly asks for linux-aio backend). But that's yet to be improved |
3 participants
When server socket sleeps in .accept() method, it should be possible to abort the waiting. The accept() should then resolve into exception of known type and error code.
refs #578