Remove global scheduling group ID bitmap #3213
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To facilitate further patching. Also, to be symmetrical with create_scheduling_supergroup(). Signed-off-by: Pavel Emelyanov <xemul@scylladb.com>
The helper initializes specific_vals for newly created sched group. The very same code will need to be added to another function in the next patch, so prepare in advance. Signed-off-by: Pavel Emelyanov <xemul@scylladb.com>
This patch adds and calls init_scheduling_group() overload that also _creates_ the scheduling group. For that it needs to allocate an id for it, and this allocation happens by scanning the task_queue-s finding for free slot in it. Other shards then just use the provided id. The goal here is to remove global bitmap with sched group ids and to make it symmetrical with how scheduling supergroup ids are allocated. Signed-off-by: Pavel Emelyanov <xemul@scylladb.com>
It's now unused and can be safely removed. Signed-off-by: Pavel Emelyanov <xemul@scylladb.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bitmap is used to allocate ID for newly created scheduling group. This PR replaces it with the logic applied in supergroup ID allocation -- the ID is "allocated" by looking up free slot in sched group pointers on shard-0, then the existing group initialization proceeds.
The main intent is to keep the sched group counting control in one place, specifically after applying per-supergroup maintenance (see #3212).