Remove DE workflow job timeout and threads override#257
Merged
Conversation
The DE integration tests have outgrown the 60-minute timeout-minutes limit — the last two runs (scheduled + dispatched) were cancelled at the hour mark with all completed tests passing. Drop the field so the GitHub Actions 6-hour default applies. Also remove the FABRIC_TEST_THREADS: 2 override so the conftest default of 10 takes effect, matching local runs. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
timeout-minutes: 60from all three jobs inintegration-tests-de.ymlso the GitHub Actions 6-hour default applies. The last two runs (dispatch, scheduled) were cancelled at exactly 1h0m with all completed tests passing — the suite simply outgrew the limit.FABRIC_TEST_THREADS: 2env override in all three jobs so the conftest fallback of 10 takes effect, matching local development.Test plan
gh workflow run integration-tests-de.yml) and confirm the run completes within the 6-hour default.🤖 Generated with Claude Code