Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion _toolbox/PR_DESCRIPTION.md
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ I tried contributing some of these fixes back to `microsoft/dbt-fabric` first, b

- [#01 — Six `__exit__` methods return `True` (silent exception swallowing)](https://github.com/sdebruyn/dbt-fabric/blob/to-toolbox/_toolbox/upstream_issues/dbt-fabricspark/01-exit-methods-return-true-swallow-exceptions.md)
- [microsoft/dbt-fabricspark#192 — Hardcoded `expires_on = 1845972874` (year 2028) in `int_tests` auth path bypasses all token refresh](https://github.com/microsoft/dbt-fabricspark/issues/192)
- [#04 — `_getLivySQL`: `re.DOTALL` passed as positional `count` caps comment-stripping at 16](https://github.com/sdebruyn/dbt-fabric/blob/to-toolbox/_toolbox/upstream_issues/dbt-fabricspark/04-getlivysql-regex-bug.md)
- [microsoft/dbt-fabricspark#194 — `_getLivySQL`: `re.DOTALL` passed as positional `count` caps comment-stripping at 16](https://github.com/microsoft/dbt-fabricspark/issues/194) (draft fix: [microsoft/dbt-fabricspark#195](https://github.com/microsoft/dbt-fabricspark/pull/195))
- [#06 — Livy session cleanup bypasses dbt's `close()` lifecycle and uses `atexit`](https://github.com/sdebruyn/dbt-fabric/blob/to-toolbox/_toolbox/upstream_issues/dbt-fabricspark/06-atexit-handlers-leak-livy-sessions.md)
- [#07 — Dead Thrift exception handler from dbt-spark ancestry](https://github.com/sdebruyn/dbt-fabric/blob/to-toolbox/_toolbox/upstream_issues/dbt-fabricspark/07-thrift-dead-code.md)
- [#08 — Proposal: inherit from `dbt-spark` instead of being a standalone `SQLAdapter`](https://github.com/sdebruyn/dbt-fabric/blob/to-toolbox/_toolbox/upstream_issues/dbt-fabricspark/08-inherit-from-dbt-spark.md)
Expand Down
4 changes: 2 additions & 2 deletions _toolbox/upstream_issues/INDEX.md
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ Each issue body carries a `> [ ] Validated by maintainer` checkbox at the top. S

- [x] 01 — Six `__exit__` methods return `True`
- [x] 02 — Hardcoded 2028 token expiry → filed as [microsoft/dbt-fabricspark#192](https://github.com/microsoft/dbt-fabricspark/issues/192)
- [x] 04 — `_getLivySQL` regex bug
- [x] 04 — `_getLivySQL` regex bug → filed as [microsoft/dbt-fabricspark#194](https://github.com/microsoft/dbt-fabricspark/issues/194), draft PR [microsoft/dbt-fabricspark#195](https://github.com/microsoft/dbt-fabricspark/pull/195)
- [x] 06 — Livy cleanup bypasses dbt's `close()` lifecycle
- [x] 07 — Thrift dead code from dbt-spark ancestry
- [x] 08 — Proposal: inherit from `dbt-spark`
Expand Down Expand Up @@ -111,7 +111,7 @@ These are debatable and may invite long discussion. File only if the second batc
|---|---|---|---|
| 01 | Six `__exit__` methods return `True` — silent exception swallowing | high | bug |
| 02 | [Hardcoded 2028 token expiry bypasses refresh logic](https://github.com/microsoft/dbt-fabricspark/issues/192) | high | bug, security |
| 04 | `_getLivySQL` regex bug: `re.DOTALL` passed as positional `count` | medium | bug |
| 04 | [`_getLivySQL` regex bug: `re.DOTALL` passed as positional `count`](https://github.com/microsoft/dbt-fabricspark/issues/194) | medium | bug |
| 06 | `atexit` handlers leak Livy sessions on hard kill / OOM | medium | bug |
| 07 | Thrift dead code from dbt-spark ancestry | low | tech-debt |
| 09 | `botocore`/`boto3` DEBUG logging at import time | low | tech-debt |
Expand Down

This file was deleted.