Skip to content

Fix plugins being reloaded each time #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
emintham wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix plugins being reloaded each time #6

emintham wants to merge 1 commit into from

Conversation

@emintham
Copy link
Contributor

@emintham emintham commented Aug 31, 2018

  • Fix plugins being reloaded each time when the path to plugins has init files.
  • The init files will be found by self._get_modules but since they are not
    plugins, they will never be registered in self._plugins. This causes plugins to
    be reloaded each time.

@emintham
Fix plugins being reloaded each time
29585aa 
- Fix plugins being reloaded each time when the path to plugins has __init__ files.
- The __init__ files will be found by `self._get_modules` but since they are not
   plugins, they will never be registered in `self._plugins`. This causes plugins to
   be reloaded each time.
@emintham
Copy link
Contributor Author

emintham commented Aug 31, 2018

Without this change, on develop, BusinessUnitReactView.get_ui_context_data takes approximately 3.3s every time. This change makes subsequent calls take 0.014s!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@emintham