Testsuite "fixes" #72
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is based on the not-networking-related part at the end of pymitler-check.patch. But it uses rc.wasSuccessful() instead of rc.failures, because there are other non-success conditions than "failure" (such as "error"), and wasSuccessful() captures those.
1) This way the filename tells us a bit about what it does, instead
of having to stumble upon a comment in pymilter.spec.
2) After the previous commit, it now really does nothing but remove
network-needing tests.
The only `makemap` Arch/Parabola have is from extra/opensmtpd, which is non-functional because it was compiled without --with-table-db.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I'm the packager for the Parabola GNU/Linux-libre distro. These are the changes we have to apply that I figured I should clean up and push upstream.
test.py: Have exit status reflect whether tests were successful
This is based on the not-networking-related part at the end of pymitler-check.patch. But it uses rc.wasSuccessful() instead of rc.failures, because there are other non-success conditions than "failure" (such as "error"), and wasSuccessful() captures those.
Rename pymilter-check.patch to test-nonet.patch
(ok, I don't really apply this in Parabola, but after the above it seemed like I should throw it in)
This way the filename tells us a bit about what it does, instead of having to stumble upon a comment in pymilter.spec.
After the previous commit, it now really does nothing but remove network-needing tests.
testpolicy: Don't rely on an external
makemapcommandThe only
makemapArch/Parabola have is from extra/opensmtpd, which is non-functional because it was compiled without --with-table-db.